[SPARK-18448][CORE] SparkSession should implement java.lang.AutoCloseable like JavaSparkContext #15932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #68854 has finished for PR 15932 at commit
|
Contributor
|
Yep that's precisely what I was envisioning. Thanks @srowen ! |
Contributor
|
Nice - given it's a tiny change I'd put this in 2.1, unless somebody else objects. @srowen ? |
Member
Author
|
Sure I'll put it in first thing tomorrow if there are no objections. |
Member
|
Great! |
Member
Author
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2016
…able like JavaSparkContext ## What changes were proposed in this pull request? Just adds `close()` + `Closeable` as a synonym for `stop()`. This makes it usable in Java in try-with-resources, as suggested by ash211 (`Closeable` extends `AutoCloseable` BTW) ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes #15932 from srowen/SPARK-18448. (cherry picked from commit db9fb9b) Signed-off-by: Sean Owen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2016
## What changes were proposed in this pull request? Fix since 2.1.0 on new SparkSession.close() method. I goofed in #15932 because it was back-ported to 2.1 instead of just master as originally planned. Author: Sean Owen <[email protected]> Closes #15938 from srowen/SPARK-18448.2.
asfgit
pushed a commit
that referenced
this pull request
Nov 19, 2016
## What changes were proposed in this pull request? Fix since 2.1.0 on new SparkSession.close() method. I goofed in #15932 because it was back-ported to 2.1 instead of just master as originally planned. Author: Sean Owen <[email protected]> Closes #15938 from srowen/SPARK-18448.2. (cherry picked from commit ded5fef) Signed-off-by: Sean Owen <[email protected]>
rxin
reviewed
Nov 19, 2016
|
|
||
| /** | ||
| * Synonym for `stop()`. | ||
| * |
Member
Author
There was a problem hiding this comment.
Yeah fixed it in a follow up.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…able like JavaSparkContext ## What changes were proposed in this pull request? Just adds `close()` + `Closeable` as a synonym for `stop()`. This makes it usable in Java in try-with-resources, as suggested by ash211 (`Closeable` extends `AutoCloseable` BTW) ## How was this patch tested? Existing tests Author: Sean Owen <[email protected]> Closes apache#15932 from srowen/SPARK-18448.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? Fix since 2.1.0 on new SparkSession.close() method. I goofed in apache#15932 because it was back-ported to 2.1 instead of just master as originally planned. Author: Sean Owen <[email protected]> Closes apache#15938 from srowen/SPARK-18448.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Just adds
close()+Closeableas a synonym forstop(). This makes it usable in Java in try-with-resources, as suggested by @ash211 (CloseableextendsAutoCloseableBTW)How was this patch tested?
Existing tests